Browse Source

Make Notification pk nullable. Fixes austinhuang0131/barinsta#1450

renovate/androidx.fragment-fragment-ktx-1.x
Ammar Githam 3 years ago
parent
commit
00945d79e7
  1. 9
      app/src/main/java/awais/instagrabber/adapters/NotificationsAdapter.java
  2. 2
      app/src/main/java/awais/instagrabber/repositories/responses/notification/Notification.kt

9
app/src/main/java/awais/instagrabber/adapters/NotificationsAdapter.java

@ -11,6 +11,7 @@ import androidx.recyclerview.widget.ListAdapter;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.stream.Collectors;
import awais.instagrabber.adapters.viewholder.NotificationViewHolder;
@ -24,12 +25,12 @@ public final class NotificationsAdapter extends ListAdapter<Notification, Notifi
private static final DiffUtil.ItemCallback<Notification> DIFF_CALLBACK = new DiffUtil.ItemCallback<Notification>() {
@Override
public boolean areItemsTheSame(final Notification oldItem, final Notification newItem) {
return oldItem.getPk().equals(newItem.getPk());
return Objects.requireNonNull(oldItem.getPk()).equals(newItem.getPk());
}
@Override
public boolean areContentsTheSame(@NonNull final Notification oldItem, @NonNull final Notification newItem) {
return oldItem.getPk().equals(newItem.getPk()) && oldItem.getType() == newItem.getType();
return Objects.requireNonNull(oldItem.getPk()).equals(newItem.getPk()) && Objects.equals(oldItem.getType(), newItem.getType());
}
};
@ -72,8 +73,8 @@ public final class NotificationsAdapter extends ListAdapter<Notification, Notifi
private List<Notification> sort(final List<Notification> list) {
final List<Notification> listCopy = new ArrayList<>(list).stream()
.filter(i -> i.getType() != null)
.collect(Collectors.toList());
.filter(i -> i.getType() != null)
.collect(Collectors.toList());
Collections.sort(listCopy, (o1, o2) -> {
// keep requests at top
if (o1.getType() == o2.getType()

2
app/src/main/java/awais/instagrabber/repositories/responses/notification/Notification.kt

@ -5,7 +5,7 @@ import awais.instagrabber.models.enums.NotificationType.Companion.valueOfType
class Notification(val args: NotificationArgs,
private val storyType: Int,
val pk: String) {
val pk: String?) {
val type: NotificationType?
get() = valueOfType(storyType)
}
Loading…
Cancel
Save