Revert "Get tabOrderString always from settings, so that it's not stale if preferences were updated"

This reverts commit b1dd0e6e3c.

app/src/main/java/awais/instagrabber/utils/Utils.java

@@ -80,6 +80,7 @@ public final class Utils {
     private static int actionBarHeight;
     public static Handler applicationHandler;
     public static String cacheDir;
+    public static String tabOrderString;
     private static int defaultStatusBarColor;
 
     public static int convertDpToPx(final float dp) {
@@ -468,7 +469,7 @@ public final class Utils {
 
     @NonNull
     private static List<String> getCurrentOrderOfGraphNamesFromPref(@NonNull final String[] navGraphNames) {
-        final String tabOrderString = settingsHelper.getString(PreferenceKeys.PREF_TAB_ORDER);
+        tabOrderString = settingsHelper.getString(PreferenceKeys.PREF_TAB_ORDER);
         final List<String> navGraphNameList = Arrays.asList(navGraphNames);
         if (TextUtils.isEmpty(tabOrderString)) {
             // Use top 5 entries for default list
@@ -490,7 +491,6 @@ public final class Utils {
     }
 
     public static boolean isNavRootInCurrentTabs(final String navRootString) {
-        final String tabOrderString = settingsHelper.getString(PreferenceKeys.PREF_TAB_ORDER);
         if (navRootString == null || tabOrderString == null) return false;
         return tabOrderString.contains(navRootString);
     }